Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to Noop classes from API #2230

Merged
merged 3 commits into from
May 27, 2021
Merged

chore: remove references to Noop classes from API #2230

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c975514
chore: remove references to Noop classes from API
dyladan May 26, 2021
23d856c
chore: add mock enable
dyladan May 26, 2021
efcfaaf
Merge branch 'main' into remove-noop-classes
dyladan May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add mock enable
  • Loading branch information
@dyladan
dyladan committed May 26, 2021
commit 23d856c2755b88449691ae5d0e2b1fe5d8d34241
2 changes: 1 addition & 1 deletion packages/opentelemetry-web/test/registration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('API registration', () => {
it('should register configured implementations', () => {
const tracerProvider = new WebTracerProvider();

const contextManager = { disable() { } } as any;
const contextManager = { disable() { }, enable() { } } as any;
const propagator = {} as any;

tracerProvider.register({
Expand Down