refactor(opentelemetry-instrumentation-http): make _getConfig public and rename to getConfig #2201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The problem occurs when socket.io uses polling as the transport method and sends an HTTP POST request, this causes a trace to be generated by the HTTP instrumentation.
The workaround we thought about was to pass the instance of
HttpInstrumentation
to our socket.io instrumentation and modify theHttpInstrumentationConfig.ignoreIncomingPaths
to include the path of the socket.io endpoint.In order to do that, we need to publicize the
_getConfig
method so we can merge the new config with the existing one and callsetConfig
.Short description of the changes
_getConfig
to getConfigprivate
topublic