Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle SDK environment variables #1921

Closed

Conversation

jtmalinowski
Copy link
Contributor

@jtmalinowski jtmalinowski commented Feb 9, 2021

Which problem is this PR solving?

Short description of the changes

@jtmalinowski jtmalinowski force-pushed the feat/sdk-env-vars branch 4 times, most recently from 8ecec4a to 59fe24c Compare February 10, 2021 18:31
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1921 (ad1b04a) into main (9f965b0) will increase coverage by 0.08%.
The diff coverage is 88.33%.

@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
+ Coverage   92.45%   92.54%   +0.08%     
==========================================
  Files         165      165              
  Lines        5463     5514      +51     
  Branches     1152     1165      +13     
==========================================
+ Hits         5051     5103      +52     
+ Misses        412      411       -1     
Impacted Files Coverage Δ
...y-api/src/context/propagation/TextMapPropagator.ts 14.28% <ø> (ø)
...kages/opentelemetry-node/src/NodeTracerProvider.ts 95.23% <80.00%> (-4.77%) ⬇️
packages/opentelemetry-tracing/src/config.ts 86.20% <85.71%> (-13.80%) ⬇️
...s/opentelemetry-tracing/src/BasicTracerProvider.ts 94.54% <87.50%> (+15.05%) ⬆️
packages/opentelemetry-api/src/api/propagation.ts 94.59% <100.00%> (+1.26%) ⬆️
...elemetry-core/src/context/propagation/composite.ts 100.00% <100.00%> (ø)
...ckages/opentelemetry-core/src/utils/environment.ts 90.00% <100.00%> (ø)
packages/opentelemetry-tracing/src/utility.ts 100.00% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@vmarchaud
Copy link
Member

@jtmalinowski I think we can close this one ?

@jtmalinowski jtmalinowski deleted the feat/sdk-env-vars branch April 20, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General environment configuration
2 participants