Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: specification compliant baggage #1876

Merged
merged 11 commits into from
Feb 5, 2021
Merged

refactor!: specification compliant baggage #1876

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fcbb29e
refactor!: specification compliant baggage
dyladan Jan 27, 2021
63b6a6e
chore: use map in baggage
dyladan Jan 28, 2021
cac13ad
Merge remote-tracking branch 'origin/main' into baggage
dyladan Jan 28, 2021
747262f
test: add baggage tests
dyladan Jan 28, 2021
cc7eb4b
Merge remote-tracking branch 'origin/main' into baggage
dyladan Feb 2, 2021
9a29a53
chore: review comments
dyladan Feb 2, 2021
b1f53e4
chore: baggage propagation test improvements
dyladan Feb 2, 2021
9821a68
chore: improve test for baggage key length
dyladan Feb 2, 2021
a188f9f
chore: add tests for clear and removeEntries
dyladan Feb 2, 2021
9e3b3a6
Merge remote-tracking branch 'origin/main' into baggage
dyladan Feb 3, 2021
56eb777
Merge remote-tracking branch 'origin/main' into baggage
dyladan Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: improve test for baggage key length
  • Loading branch information
@dyladan
dyladan committed Feb 2, 2021
commit 9821a68115f679288ba97e84b99aba3cde8dc881
23 changes: 21 additions & 2 deletions packages/opentelemetry-core/test/baggage/HttpBaggage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,36 @@ describe('HttpBaggage', () => {
const shortKey = Array(95).fill('k').join('');
const value = Array(4000).fill('v').join('');

const baggage = createBaggage({
let baggage = createBaggage({
aa: { value: 'shortvalue' },
[shortKey]: { value: value },
});

httpTraceContext.inject(
setBaggage(ROOT_CONTEXT, baggage),
carrier,
defaultTextMapSetter
);

let header = carrier[BAGGAGE_HEADER];
assert.ok(typeof header === 'string');
assert.deepStrictEqual(header, `aa=shortvalue,${shortKey}=${value}`);

baggage = createBaggage({
aa: { value: 'shortvalue' },
[longKey]: { value: value },
});

carrier = {};
httpTraceContext.inject(
setBaggage(ROOT_CONTEXT, baggage),
carrier,
defaultTextMapSetter
);

assert.deepStrictEqual(carrier[BAGGAGE_HEADER], `${shortKey}=${value}`);
header = carrier[BAGGAGE_HEADER];
assert.ok(typeof header === 'string');
assert.deepStrictEqual(header, 'aa=shortvalue');
});

it('should not exceed the W3C standard header length limit of 8192 bytes', () => {
Expand Down Expand Up @@ -122,6 +140,7 @@ describe('HttpBaggage', () => {
aa: { value: Array(89).fill('v').join('') },
});

carrier = {};
httpTraceContext.inject(
setBaggage(ROOT_CONTEXT, baggage),
carrier,
Expand Down