-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CircleCI unit test workflow to Github Actions #1711
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1711 +/- ##
==========================================
+ Coverage 91.84% 91.91% +0.07%
==========================================
Files 167 167
Lines 5567 5567
Branches 1183 1183
==========================================
+ Hits 5113 5117 +4
+ Misses 454 450 -4
|
.github/workflows/unit-test.yml
Outdated
|
||
jobs: | ||
unit-test: | ||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is supposed to be in the stragegy
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight slip (didn't notice since test passed). Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test didn't actually run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have added it last second then 😅 It should be working now.
I notice you didn't remove circleci. Was that on purpose? |
Yes, it was intentional to have them running in parallel for a week for comparison, but I suppose logs can be viewed for that purpose. Removing ci.yml config file. I deleted the file, but to actually remove CircleCI from the repo, a maintainer needs to remove the CircleCi webhook in the repository settings before merging this PR. |
Can this PR and the related contrib PR (open-telemetry/opentelemetry-js-contrib#272) be merged now that they are approved and rebased? |
@shovnik I was about to merge this but I don't have permission to fix the conflict. |
@dyladan I just fixed the conflict. Let me know if there are any other issues. |
Which problem is this PR solving?
Short description of the changes
Migration Plan
I suggest having CircleCI and GitHub Action jobs run in parallel for a few weeks. After the GitHub Action jobs are running fine for a week or so and then remove the CircleCI workflows from config.yml
Note: Related PR migrating the corresponding config.yml file in the opentelemetry-js-contrib repo.
cc - @alolita