-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exporter-collector): log upstream error #1459 #1607
feat(exporter-collector): log upstream error #1459 #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code wise it looks finne, can you fix build as it is failing everywhere ?
dbe85d4
to
af95af1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
- Coverage 91.35% 91.32% -0.04%
==========================================
Files 165 160 -5
Lines 5042 4771 -271
Branches 1040 978 -62
==========================================
- Hits 4606 4357 -249
+ Misses 436 414 -22 |
a2600de
to
d2b21ba
Compare
@obecny I've rebased and fixed the build ! PTAL |
9561042
to
354ea24
Compare
cc @open-telemetry/javascript-approvers this one only need one more review :) |
As stated in the issue, before it was impossible to know why we couldnt push to the collector.