chore(node-sdk): use warn log level when enabled plugin arent installed #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
OlivierAlbertini
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1526 +/- ##
=======================================
Coverage 93.82% 93.83%
=======================================
Files 154 154
Lines 4762 4765 +3
Branches 951 954 +3
=======================================
+ Hits 4468 4471 +3
Misses 294 294
|
naseemkullah
approved these changes
Sep 13, 2020
naseemkullah
requested changes
Sep 14, 2020
naseemkullah
approved these changes
Sep 14, 2020
dyladan
reviewed
Sep 14, 2020
| `PluginLoader#load: could not load plugin ${modulePath} of module ${name}. Error: ${e.message}` | ||
| } catch (err) { | ||
| const logLevel = | ||
| err instanceof Error && err.message.match(/Cannot find module/) |
There was a problem hiding this comment.
Would it be better to match on error.code which is a more stable error identifier?
https://nodejs.org/api/errors.html#errors_error_code
https://nodejs.org/api/errors.html#errors_err_module_not_found
https://nodejs.org/api/errors.html#errors_module_not_found
|
Closing because @obecny will refactor the plugin loader and it will not be a problem (ref #1124 (comment)) |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1124