Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add c8 settings #141

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Conversation

mayurkale22
Copy link
Member

Example:

Without settings:

---------------------------|----------|----------|----------|----------|-------------------|
File                       |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
---------------------------|----------|----------|----------|----------|-------------------|
All files                  |    96.95 |    66.67 |      100 |    96.95 |                   |
 AsyncHooksScopeManager.ts |    96.49 |    62.96 |      100 |    96.49 |       41,48,49,50 |
 index.ts                  |      100 |      100 |      100 |      100 |                   |
---------------------------|----------|----------|----------|----------|-------------------|

With settings:

---------------------------------|----------|----------|----------|----------|-------------------|
File                             |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
---------------------------------|----------|----------|----------|----------|-------------------|
All files                        |    97.15 |    74.14 |      100 |    97.15 |                   |
 src                             |    96.49 |    62.96 |      100 |    96.49 |                   |
  AsyncHooksScopeManager.ts      |    96.49 |    62.96 |      100 |    96.49 |       41,48,49,50 |
 test/asynchooks                 |    97.73 |    83.87 |      100 |    97.73 |                   |
  AsyncHooksScopeManager.test.ts |    97.73 |    83.87 |      100 |    97.73 |         72,73,129 |
---------------------------------|----------|----------|----------|----------|-------------------|

@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #141 into master will decrease coverage by 2.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   97.66%   95.18%   -2.48%     
==========================================
  Files          38       41       +3     
  Lines        2652     3284     +632     
  Branches      304      389      +85     
==========================================
+ Hits         2590     3126     +536     
- Misses         62      158      +96
Impacted Files Coverage Δ
...kages/opentelemetry-scope-async-hooks/src/index.ts
packages/opentelemetry-scope-base/src/index.ts
...oks/test/asynchooks/AsyncHooksScopeManager.test.ts 84.09% <0%> (ø)
...etry-scope-base/test/noop/NoopScopeManager.test.ts 77.17% <0%> (ø)
...pentelemetry-basic-tracer/test/BasicTracer.test.ts 83.01% <0%> (ø)
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <0%> (ø)
.../opentelemetry-node-tracer/test/NodeTracer.test.ts 85.24% <0%> (ø)

Copy link
Member

@rochdev rochdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a dot file that can be used instead? Also, can it be shared instead of repeating the setting in every package?

@mayurkale22
Copy link
Member Author

Is there a dot file that can be used instead? Also, can it be shared instead of repeating the setting in every package?

Added .nycrc file

@mayurkale22 mayurkale22 merged commit 487fdb2 into open-telemetry:master Aug 1, 2019
@mayurkale22 mayurkale22 deleted the c8_settings branch August 1, 2019 16:46
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* chore: add c8 settings

* fix: add .nycrc
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants