Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore non-number value on BaseBoundInstrument.update #1366

Merged
merged 12 commits into from
Aug 20, 2020
Merged

fix: ignore non-number value on BaseBoundInstrument.update #1366

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
93d923b
fix: skip non-number value on BaseBoundInstrument.update
legendecas Jul 29, 2020
60c7974
Merge remote-tracking branch 'upstream/master' into non-number-update
legendecas Aug 3, 2020
660538e
test: iterates a set of non-number values for test
legendecas Aug 3, 2020
5a67737
test: iterates float point values on truncating of non-integer values
legendecas Aug 3, 2020
56521b7
feat: use @ts-expect-error directive on testing arbitrary types
legendecas Aug 3, 2020
ae07012
test: unused parameter val in iteration
legendecas Aug 3, 2020
9ff4219
test: add more type tests
legendecas Aug 3, 2020
e793a68
fix: bigint literal is not supported with Node.js v8.x
legendecas Aug 4, 2020
4e9de29
Merge branch 'master' into non-number-update
legendecas Aug 4, 2020
0e07065
Merge branch 'master' into non-number-update
legendecas Aug 17, 2020
63eb24b
Merge branch 'master' into non-number-update
obecny Aug 19, 2020
5a51e93
Merge branch 'master' into non-number-update
dyladan Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: iterates a set of non-number values for test
  • Loading branch information
@legendecas
legendecas committed Aug 3, 2020
commit 660538e6720c333dcbb2e0e3ede4e2797b4cc5a3
111 changes: 47 additions & 64 deletions packages/opentelemetry-metrics/test/Meter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ import { hashLabels } from '../src/Utils';
import { Batcher } from '../src/export/Batcher';
import { ValueType } from '@opentelemetry/api';

const nonNumberValues = [undefined, Symbol('123'), {}];

describe('Meter', () => {
let meter: Meter;
const keya = 'keya';
Expand Down Expand Up @@ -376,7 +378,7 @@ describe('Meter', () => {
assert.strictEqual(boundCounter, boundCounter1);
});

it('should trunk non-integer values for INT valueType', async () => {
it('should truncate non-integer values for INT valueType', async () => {
const upDownCounter = meter.createUpDownCounter('name', {
valueType: ValueType.INT,
});
Expand All @@ -388,24 +390,24 @@ describe('Meter', () => {

assert.strictEqual(record1.aggregator.toPoint().value, -1);
}
});

{
// disable type checking...
(boundCounter.add as any)(undefined);
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();

assert.strictEqual(record1.aggregator.toPoint().value, -1);
}
it('should ignore non-number values for INT valueType', async () => {
const upDownCounter = meter.createUpDownCounter('name', {
valueType: ValueType.DOUBLE,
});
const boundCounter = upDownCounter.bind(labels);

{
// disable type checking...
(boundCounter.add as any)({});
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();
await Promise.all(
nonNumberValues.map(async val => {
// disable type checking...
(boundCounter.add as any)(val);
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();

assert.strictEqual(record1.aggregator.toPoint().value, -1);
}
assert.strictEqual(record1.aggregator.toPoint().value, 0);
})
);
});

it('should ignore non-number values for DOUBLE valueType', async () => {
Expand All @@ -414,23 +416,16 @@ describe('Meter', () => {
});
const boundCounter = upDownCounter.bind(labels);

{
// disable type checking...
(boundCounter.add as any)(undefined);
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();

assert.strictEqual(record1.aggregator.toPoint().value, 0);
}
await Promise.all(
nonNumberValues.map(async val => {
// disable type checking...
(boundCounter.add as any)(val);
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();

{
// disable type checking...
(boundCounter.add as any)({});
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();

assert.strictEqual(record1.aggregator.toPoint().value, 0);
}
assert.strictEqual(record1.aggregator.toPoint().value, 0);
})
);
});
});

Expand Down Expand Up @@ -715,38 +710,26 @@ describe('Meter', () => {
'name'
) as ValueRecorderMetric;
const boundValueRecorder = valueRecorder.bind(labels);
{
// disable type checking...
(boundValueRecorder.record as any)(undefined);
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();
assert.deepStrictEqual(
record1.aggregator.toPoint().value as Distribution,
{
count: 0,
last: 0,
max: -Infinity,
min: Infinity,
sum: 0,
}
);
}
{
// disable type checking...
(boundValueRecorder.record as any)({});
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();
assert.deepStrictEqual(
record1.aggregator.toPoint().value as Distribution,
{
count: 0,
last: 0,
max: -Infinity,
min: Infinity,
sum: 0,
}
);
}

await Promise.all(
nonNumberValues.map(async val => {
// disable type checking...
(boundValueRecorder.record as any)(undefined);
await meter.collect();
const [record1] = meter.getBatcher().checkPointSet();

assert.deepStrictEqual(
record1.aggregator.toPoint().value as Distribution,
{
count: 0,
last: 0,
max: -Infinity,
min: Infinity,
sum: 0,
}
);
})
);
});
});

Expand Down