Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing a list of files to be in unit test coverage report #1091

Merged
merged 4 commits into from
May 26, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented May 21, 2020

Which problem is this PR solving?

  • the list of files for coverage report should be only a src code not unit tests itself, as well as files which are configurations should be also skipped

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #1091 into master will decrease coverage by 2.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   94.98%   92.34%   -2.64%     
==========================================
  Files         238      115     -123     
  Lines        9085     3398    -5687     
  Branches      822      684     -138     
==========================================
- Hits         8629     3138    -5491     
+ Misses        456      260     -196     
Impacted Files Coverage Δ
...ges/opentelemetry-exporter-zipkin/test/e2e.test.ts
packages/opentelemetry-metrics/test/Meter.test.ts
...s/opentelemetry-shim-opentracing/test/Shim.test.ts
...s/opentelemetry-context-zone-peer-dep/.eslintrc.js
...ckages/opentelemetry-core/test/platform/id.test.ts
packages/opentelemetry-plugin-http/.eslintrc.js
...ntelemetry-node/test/instrumentation/utils.test.ts
packages/opentelemetry-api/test/api/api.test.ts
...ages/opentelemetry-plugin-http/test/utils/utils.ts
...y-tracing/test/export/InMemorySpanExporter.test.ts
... and 113 more

@dyladan dyladan merged commit da11e1b into open-telemetry:master May 26, 2020
@obecny obecny deleted the coverage_files branch July 8, 2020 12:12
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants