Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC plugin #158

Closed
mayurkale22 opened this issue Aug 2, 2019 · 5 comments
Closed

Add gRPC plugin #158

mayurkale22 opened this issue Aug 2, 2019 · 5 comments
Assignees
@markwolff
Labels
feature-request
Milestone
Basic Plugins

Comments

@mayurkale22
Copy link
Member

Add opentelemetry-plugin-grpc to allow the user to automatically collect trace data. This should be based on BasePlugin interface: https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-core/src/trace/instrumentation/BasePlugin.ts#L20

OpenCensus reference implementation : https://github.com/census-instrumentation/opencensus-node/tree/master/packages/opencensus-instrumentation-grpc
@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Aug 2, 2019
@OlivierAlbertini OlivierAlbertini mentioned this issue Aug 3, 2019
Closed
@markwolff
Copy link
Member

@OlivierAlbertini are you working this? Else I can claim it. @mayurkale22

@mayurkale22
Copy link
Member Author

Hey @markwolff welcome back! AFAIK no one is working on this, @OlivierAlbertini Could you please confirm the same?

@vmarchaud
Copy link
Member

From his message on the gitter is on holiday until friday but i'm pretty sure he's only worked on the http plugin

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 13, 2019
@OlivierAlbertini
Copy link
Member

Hey @markwolff welcome back! AFAIK no one is working on this, @OlivierAlbertini Could you please confirm the same?

I confirm

@markwolff markwolff mentioned this issue Aug 22, 2019
Merged
3 tasks
@mayurkale22 mayurkale22 mentioned this issue Aug 23, 2019
Merged
@markwolff markwolff mentioned this issue Sep 9, 2019
Merged
@mayurkale22 mayurkale22 mentioned this issue Sep 10, 2019
Closed
@mayurkale22
Copy link
Member Author

Closed via #215

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@obecny
Merge pull request open-telemetry#158 from johnbley/master
4e551ad 
fix: patch removeEventListener to properly remove patched callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwolff markwolff

Labels
feature-request
Projects
None yet
Milestone
Basic Plugins
Development

No branches or pull requests
4 participants
@vmarchaud @OlivierAlbertini @markwolff @mayurkale22