fixup! feat(sdk-trace-base)!: drop ability to instantiate propagators…

… beyond defaults
open-telemetry · Jan 30, 2025 · 6a4a5af · 6a4a5af
1 parent 78aca13
commit 6a4a5af
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/experimental/packages/opentelemetry-sdk-node/src/sdk.ts b/experimental/packages/opentelemetry-sdk-node/src/sdk.ts
@@ -74,7 +74,7 @@ import {
   getResourceDetectorsFromEnv,
   getSpanProcessorsFromEnv,
   filterBlanksAndNulls,
-  getPropgagatorFromEnv,
+  getPropagatorFromEnv,
 } from './utils';
 
 /** This class represents everything needed to register a fully configured OpenTelemetry Node.js SDK */
@@ -379,7 +379,7 @@ export class NodeSDK {
           this._configuration?.contextManager,
         propagator:
           this._tracerProviderConfig?.textMapPropagator ??
-          getPropgagatorFromEnv(),
+          getPropagatorFromEnv(),
       });
     }
 

diff --git a/experimental/packages/opentelemetry-sdk-node/src/utils.ts b/experimental/packages/opentelemetry-sdk-node/src/utils.ts
@@ -191,7 +191,7 @@ export function getSpanProcessorsFromEnv(): SpanProcessor[] {
 /**
  * Get a propagator as defined by environment variables
  */
-export function getPropgagatorFromEnv(): TextMapPropagator | null | undefined {
+export function getPropagatorFromEnv(): TextMapPropagator | null | undefined {
   // Empty and undefined MUST be treated equal.
   if (
     process.env.OTEL_PROPAGATORS === undefined ||

diff --git a/experimental/packages/opentelemetry-sdk-node/test/utils.test.ts b/experimental/packages/opentelemetry-sdk-node/test/utils.test.ts
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { getPropgagatorFromEnv } from '../src/utils';
+import { getPropagatorFromEnv } from '../src/utils';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
 import { diag } from '@opentelemetry/api';
@@ -29,39 +29,39 @@ describe('getPropagatorFromEnv', function () {
     it('when not defined', function () {
       delete process.env.OTEL_PROPAGATORS;
 
-      const propagator = getPropgagatorFromEnv();
+      const propagator = getPropagatorFromEnv();
 
       assert.deepStrictEqual(propagator, undefined);
     });
 
     it('on empty string', function () {
       (process.env as any).OTEL_PROPAGATORS = '';
 
-      const propagator = getPropgagatorFromEnv();
+      const propagator = getPropagatorFromEnv();
 
       assert.deepStrictEqual(propagator, undefined);
     });
 
     it('on space-only string', function () {
       (process.env as any).OTEL_PROPAGATORS = '   ';
 
-      const propagator = getPropgagatorFromEnv();
+      const propagator = getPropagatorFromEnv();
 
       assert.deepStrictEqual(propagator, undefined);
     });
   });
 
   it('should return the selected propagator when one is in the list', () => {
     process.env.OTEL_PROPAGATORS = 'tracecontext';
-    assert.deepStrictEqual(getPropgagatorFromEnv()?.fields(), [
+    assert.deepStrictEqual(getPropagatorFromEnv()?.fields(), [
       'traceparent',
       'tracestate',
     ]);
   });
 
   it('should return the selected propagators when multiple are in the list', () => {
     process.env.OTEL_PROPAGATORS = 'tracecontext,baggage,b3,b3multi,jaeger';
-    assert.deepStrictEqual(getPropgagatorFromEnv()?.fields(), [
+    assert.deepStrictEqual(getPropagatorFromEnv()?.fields(), [
       'traceparent',
       'tracestate',
       'b3',
@@ -78,7 +78,7 @@ describe('getPropagatorFromEnv', function () {
     const warnStub = sinon.stub(diag, 'warn');
 
     process.env.OTEL_PROPAGATORS = 'my, unknown, propagators';
-    assert.deepStrictEqual(getPropgagatorFromEnv(), null);
+    assert.deepStrictEqual(getPropagatorFromEnv(), null);
     sinon.assert.calledWithExactly(
       warnStub,
       'Propagator "my" requested through environment variable is unavailable.'
@@ -97,6 +97,6 @@ describe('getPropagatorFromEnv', function () {
   it('should return null if only "none" is selected', () => {
     process.env.OTEL_PROPAGATORS = 'none';
 
-    assert.deepStrictEqual(getPropgagatorFromEnv(), null);
+    assert.deepStrictEqual(getPropagatorFromEnv(), null);
   });
 });