test(sdk-metrics): test that NaN is ignored by histogram accumulations

open-telemetry · Feb 1, 2024 · 4c7ca1a · 4c7ca1a
1 parent d046310
commit 4c7ca1a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/packages/sdk-metrics/test/aggregator/ExponentialHistogram.test.ts b/packages/sdk-metrics/test/aggregator/ExponentialHistogram.test.ts
@@ -215,6 +215,18 @@ describe('ExponentialHistogramAccumulation', () => {
         }
       });
     });
+
+    it('ignores NaN', () => {
+      const accumulation = new ExponentialHistogramAccumulation([0, 0], 1);
+      accumulation.record(NaN);
+      assert.strictEqual(accumulation.scale, 0);
+      assert.strictEqual(accumulation.max, -Infinity);
+      assert.strictEqual(accumulation.min, Infinity);
+      assert.strictEqual(accumulation.sum, 0);
+      assert.strictEqual(accumulation.count, 0);
+      assert.deepStrictEqual(getCounts(accumulation.positive), []);
+      assert.deepStrictEqual(getCounts(accumulation.negative), []);
+    });
   });
   describe('merge', () => {
     it('handles simple (even) case', () => {

diff --git a/packages/sdk-metrics/test/aggregator/Histogram.test.ts b/packages/sdk-metrics/test/aggregator/Histogram.test.ts
@@ -257,6 +257,18 @@ describe('HistogramAccumulation', () => {
         accumulation.record(value);
       }
     });
+
+    it('ignores NaN', () => {
+      const accumulation = new HistogramAccumulation([0, 0], [1, 10, 100]);
+      accumulation.record(NaN);
+
+      const pointValue = accumulation.toPointValue();
+      assert.strictEqual(pointValue.max, -Infinity);
+      assert.strictEqual(pointValue.min, Infinity);
+      assert.strictEqual(pointValue.sum, 0);
+      assert.strictEqual(pointValue.count, 0);
+      assert.deepStrictEqual(pointValue.buckets.counts, [0, 0, 0, 0]);
+    });
   });
 
   describe('setStartTime', () => {