test: refactor ConsoleLogRecordExporter assertions

open-telemetry · Mar 11, 2024 · 24a025c · 24a025c
1 parent 381faa2
commit 24a025c
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/experimental/packages/sdk-logs/test/common/export/ConsoleLogRecordExporter.test.ts b/experimental/packages/sdk-logs/test/common/export/ConsoleLogRecordExporter.test.ts
@@ -44,13 +44,13 @@ describe('ConsoleLogRecordExporter', () => {
         severityNumber: SeverityNumber.DEBUG,
         severityText: 'DEBUG',
       });
-      const consoleOutput = stdoutStub.getCalls()[0].firstArg;
       stdoutStub.restore();
 
       const logRecords = spyExport.args[0];
       const firstLogRecord = logRecords[0][0];
       const consoleArgs = consoleSpy.args[0];
       const consoleLogRecord = consoleArgs[0];
+      const consoleDirOpts = consoleArgs[1];
       const keys = Object.keys(consoleLogRecord).sort().join(',');
       consoleSpy.restore();
 
@@ -69,15 +69,8 @@ describe('ConsoleLogRecordExporter', () => {
       assert.equal(firstLogRecord.severityNumber, SeverityNumber.DEBUG);
       assert.equal(firstLogRecord.severityText, 'DEBUG');
       assert.equal(keys, expectedKeys);
-
+      assert.equal(consoleDirOpts.colors, undefined);
       assert.ok(spyExport.calledOnce);
-
-      const containsColor = isColorText(consoleOutput);
-      assert.equal(
-        containsColor,
-        (process.env.FORCE_COLOR && process.env.FORCE_COLOR !== '0') ||
-          process.stdout.isTTY
-      );
     });
     it('should colorize log records', () => {
       const consoleExporter = new ConsoleLogRecordExporter({ colors: true });
@@ -86,15 +79,19 @@ describe('ConsoleLogRecordExporter', () => {
         new SimpleLogRecordProcessor(consoleExporter)
       );
 
+      const consoleSpy = sinon.spy(console, 'dir');
       const stdoutStub = sinon.stub(process.stdout, 'write');
       provider.getLogger('default').emit({
         body: 'body2',
         severityNumber: SeverityNumber.DEBUG,
         severityText: 'DEBUG',
       });
       const consoleOutput = stdoutStub.getCalls()[0].firstArg;
+      const consoleDirOpts = consoleSpy.args[0][1];
       stdoutStub.restore();
+      consoleSpy.restore();
 
+      assert.equal(consoleDirOpts.colors, true);
       const containsColor = isColorText(consoleOutput);
       assert.ok(containsColor);
     });
@@ -105,15 +102,19 @@ describe('ConsoleLogRecordExporter', () => {
         new SimpleLogRecordProcessor(consoleExporter)
       );
 
+      const consoleSpy = sinon.spy(console, 'dir');
       const stdoutStub = sinon.stub(process.stdout, 'write');
       provider.getLogger('default').emit({
         body: 'body3',
         severityNumber: SeverityNumber.DEBUG,
         severityText: 'DEBUG',
       });
       const consoleOutput = stdoutStub.getCalls()[0].firstArg;
+      const consoleDirOpts = consoleSpy.args[0][1];
       stdoutStub.restore();
+      consoleSpy.restore();
 
+      assert.equal(consoleDirOpts.colors, false);
       const doesNotContainColor = !isColorText(consoleOutput);
       assert.ok(doesNotContainColor);
     });