Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove colors dependency #943

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Mar 14, 2022

Which problem is this PR solving?

Flawed colors packages are now removed from the registry.
That should give enough time for maintainers to fix their deps that already haven't.

fixes #826

@rauno56 rauno56 requested a review from a team March 14, 2022 14:55
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #943 (2f2f7fa) into main (491588f) will decrease coverage by 3.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   95.91%   92.35%   -3.57%     
==========================================
  Files          13       25      +12     
  Lines         856     1268     +412     
  Branches      178      251      +73     
==========================================
+ Hits          821     1171     +350     
- Misses         35       97      +62     
Impacted Files Coverage Δ
...emetry-id-generator-aws-xray/src/platform/index.ts 100.00% <0.00%> (ø)
...er-extension-autoinjection/src/background/index.ts 0.00% <0.00%> (ø)
...r-aws-xray/src/platform/node/AWSXRayIdGenerator.ts 100.00% <0.00%> (ø)
...extension-autoinjection/src/contentScript/index.ts 0.00% <0.00%> (ø)
...-instrumentation-aws-lambda/src/instrumentation.ts 90.72% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.91% <0.00%> (ø)
...try-instrumentation-winston/src/instrumentation.ts 57.95% <0.00%> (ø)
...ction/src/contentScript/InstrumentationInjector.ts 100.00% <0.00%> (ø)
...rc/background/ProgrammaticContentScriptInjector.ts 100.00% <0.00%> (ø)
...metry-browser-extension-autoinjection/src/types.ts 90.32% <0.00%> (ø)
... and 2 more

@rauno56 rauno56 merged commit b21b96c into open-telemetry:main Mar 16, 2022
@rauno56 rauno56 deleted the fix/roll-colors-back branch March 16, 2022 10:47
@dyladan dyladan mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert #825: colors terminal DOS
7 participants