fix: lint failure in ci due to hoisting #649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Looks like
eslint.config.js
is referencing a file innode_modules
which is now not accessible.Short description of the changes
gts
to theno-hoist
list only for linting workflow. this should fix the workflow I believe.This PR is only for fixing the current CI issue, but for the long run, I suggest executing the linting from the repo root and not per package. This has the following advantages:
gts
, repeated the lint scripts in package.json, and include.eslintignore
and.eslintrc.js
for each package again and again)eslint
once from root. As lint failure in CI is very common, the project can benefit from speeding up feedback on this specific workflow IMO.We can discuss improvements on the SIG.