chore: propagate context on AWS Lambda Instrumentation #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, spans created in the lambda function are not part of the same trace as the handler span.
gregoryfranklin
force-pushed
the
lambda_context
branch
from
50952da to
18921b9
Compare
Codecov Report
@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 21 21
Lines 695 695
Branches 95 95
=======================================
Hits 668 668
Misses 27 27 |
vmarchaud
approved these changes
Apr 16, 2021
obecny
approved these changes
Apr 16, 2021
| @@ -24,7 +24,9 @@ import { | |||
| safeExecuteInTheMiddle, | |||
| } from '@opentelemetry/instrumentation'; | |||
| import { | |||
| context as otelcontext, | |||
There was a problem hiding this comment.
a typo ?
Suggested change
| context as otelcontext, | |
| context as otelContext, |
dyladan
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Context is not propagated. This means the span created by the AWS Lambda Instrumentation is not part of the same trace as spans created within the lambda function.
Short description of the changes
Add the span created by the AWS Lambda Instrumentation to the context that the lamdba function is run with.