-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hapi compilation #407
Conversation
Fix compilation issues by pinning @hapi/podium to 4.1.1 as later version has it's own typings which is not compatible with remaining dependencies.
Once you get past the hapi stage you will need to apply a3f5b0d too probably |
An alternative to this change would be most likely that one described in hapi issue tracker: hapijs/hapi#4240 (comment) |
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 11 11
Lines 431 431
Branches 48 48
=======================================
Hits 407 407
Misses 24 24 |
I cherry-picked this change. But honestly speaking I'm not a big fan of this. I think we should move to 0.18.2 everywhere instead at a few locations only. |
I agree, but this is the minimum to fix the currently broken compile and it is a dev dependency only |
Short description of the changes
Fix compilation issues by pinning @hapi/podium to 4.1.1 as later version has it's own typings which is not compatible with remaining dependencies.