Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hapi compilation #407

Merged
merged 2 commits into from
Apr 1, 2021
Merged

fix: hapi compilation #407

merged 2 commits into from
Apr 1, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Apr 1, 2021

Short description of the changes

Fix compilation issues by pinning @hapi/podium to 4.1.1 as later version has it's own typings which is not compatible with remaining dependencies.

Fix compilation issues by pinning @hapi/podium to 4.1.1 as later version has
it's own typings which is not compatible with remaining dependencies.
@Flarna Flarna requested a review from a team April 1, 2021 16:44
@dyladan
Copy link
Member

dyladan commented Apr 1, 2021

Once you get past the hapi stage you will need to apply a3f5b0d too probably

@Flarna
Copy link
Member Author

Flarna commented Apr 1, 2021

An alternative to this change would be most likely that one described in hapi issue tracker: hapijs/hapi#4240 (comment)

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #407 (bd3d747) into main (f106054) will not change coverage.
The diff coverage is n/a.

❗ Current head bd3d747 differs from pull request most recent head 55d0f44. Consider uploading reports for the commit 55d0f44 to get more accurate results

@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files          11       11           
  Lines         431      431           
  Branches       48       48           
=======================================
  Hits          407      407           
  Misses         24       24           

@Flarna
Copy link
Member Author

Flarna commented Apr 1, 2021

Once you get past the hapi stage you will need to apply a3f5b0d too probably

I cherry-picked this change. But honestly speaking I'm not a big fan of this. I think we should move to 0.18.2 everywhere instead at a few locations only.

@dyladan
Copy link
Member

dyladan commented Apr 1, 2021

Once you get past the hapi stage you will need to apply a3f5b0d too probably

I cherry-picked this change. But honestly speaking I'm not a big fan of this. I think we should move to 0.18.2 everywhere instead at a few locations only.

I agree, but this is the minimum to fix the currently broken compile and it is a dev dependency only

@obecny obecny merged commit a40df3c into open-telemetry:main Apr 1, 2021
@Flarna Flarna deleted the fix-hapi branch April 1, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants