Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(undici): Fix homepage url #2252

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

tastypackets
Copy link
Contributor

Which problem is this PR solving?

  • URL currently points to invalid git location
image

Short description of the changes

  • Fix Undici homepage url in package.json

URL currently points to invalid git location
@david-luna
Copy link
Contributor

Good catch @tastypackets! At the beginning the instrumentation was on a different folder and forgot to change it 🤦

@trentm I have to ask you to approve the workflow and merge since I do not have enough permissions

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (dfb2dff) to head (9b01fcf).
Report is 149 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   90.97%   90.40%   -0.58%     
==========================================
  Files         146      149       +3     
  Lines        7492     7514      +22     
  Branches     1502     1573      +71     
==========================================
- Hits         6816     6793      -23     
- Misses        676      721      +45     

see 52 files with indirect coverage changes

@trentm trentm merged commit 54d0510 into open-telemetry:main Jun 5, 2024
16 checks passed
@tastypackets tastypackets deleted the patch-1 branch October 2, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants