-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(azure-functions-resource-detector): Update Azure Functions Detector to Consider WEBSITE_SKU #2251
fix(azure-functions-resource-detector): Update Azure Functions Detector to Consider WEBSITE_SKU #2251
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
==========================================
- Coverage 90.97% 90.39% -0.59%
==========================================
Files 146 149 +3
Lines 7492 7525 +33
Branches 1502 1578 +76
==========================================
- Hits 6816 6802 -14
- Misses 676 723 +47
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few nits :)
detectors/node/opentelemetry-resource-detector-azure/src/types.ts
Outdated
Show resolved
Hide resolved
...ors/node/opentelemetry-resource-detector-azure/test/detectors/AzureFunctionsDetector.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which problem is this PR solving?
Short description of the changes
FUNCTIONS_EXTENSION_VERSION
may be undefined, in which case we should also check theWEBSITE_SKU
for the valueFlexConsumption
to determine if we still may be running in an Azure Function.