-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove redundant migration text from READMEs #2243
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2243 +/- ##
==========================================
- Coverage 90.97% 90.30% -0.68%
==========================================
Files 146 147 +1
Lines 7492 7263 -229
Branches 1502 1509 +7
==========================================
- Hits 6816 6559 -257
- Misses 676 704 +28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should instr-socket.io be done as well?
https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/instrumentation-socket.io/README.md#migration-from-opentelemetry-instrumentation-socketio
Yes, I think we should also do the same to that package. |
removed the text from socket.io as well. Thanks! |
instrumentations
aws-sdk
,mongoose
andamqplib
where originally hosted in aspect repo https://github.com/aspecto-io/opentelemetry-ext-jsWhen upstreaming them to the contrib repo, I added migration instructions for people who might be migrating from the old to the new package.
Since few years has pass, I think this info is no longer relevant or needed in the README