fix: missing .fields() method in jaeger propagator (#268)

open-telemetry · Dec 8, 2020 · d896904 · d896904
1 parent 6449f22
commit d896904
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/propagators/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts b/propagators/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts
@@ -80,6 +80,10 @@ export class JaegerHttpTracePropagator implements TextMapPropagator {
 
     return setExtractedSpanContext(context, spanContext);
   }
+
+  fields(): string[] {
+    return [this._jaegerTraceHeader];
+  }
 }
 
 /**

diff --git a/propagators/opentelemetry-propagator-jaeger/test/JaegerHttpTracePropagator.test.ts b/propagators/opentelemetry-propagator-jaeger/test/JaegerHttpTracePropagator.test.ts
@@ -172,6 +172,19 @@ describe('JaegerHttpTracePropagator', () => {
     });
   });
 
+  describe('.fields()', () => {
+    it('returns the default header if not customized', () => {
+      assert.deepStrictEqual(jaegerHttpTracePropagator.fields(), [
+        'uber-trace-id',
+      ]);
+    });
+    it('returns the customized header if customized', () => {
+      assert.deepStrictEqual(customJaegerHttpTracePropagator.fields(), [
+        customHeader,
+      ]);
+    });
+  });
+
   it('should fail gracefully on bad responses from getter', () => {
     const ctx1 = jaegerHttpTracePropagator.extract(
       ROOT_CONTEXT,
-Original file line number
+Diff line change
@@ Expand Up @@
         return setExtractedSpanContext(context, spanContext);
       }
+      fields(): string[] {
+        return [this._jaegerTraceHeader];
+      }
     }
     /**
@@ Expand Down @@