chore(instrumentation-runtime-node): set default monitoringPrecision …

…to 10ms, change scrape method to private
open-telemetry · Jul 16, 2024 · 5efdd9d · 5efdd9d
1 parent 6a84254
commit 5efdd9d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/plugins/node/instrumentation-runtime-node/src/instrumentation.ts b/plugins/node/instrumentation-runtime-node/src/instrumentation.ts
@@ -25,7 +25,7 @@ import { HeapSpacesSizeAndUsedCollector } from './metrics/heapSpacesSizeAndUsedC
 import { ConventionalNamePrefix } from './types/ConventionalNamePrefix';
 
 const DEFAULT_CONFIG: RuntimeNodeInstrumentationConfig = {
-  monitoringPrecision: 5000,
+  monitoringPrecision: 10,
 };
 
 export class RuntimeNodeInstrumentation extends InstrumentationBase {

diff --git a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopDelayCollector.ts b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopDelayCollector.ts
@@ -167,7 +167,7 @@ export class EventLoopDelayCollector extends BaseCollector {
     this._histogram.disable();
   }
 
-  protected scrape(): EventLoopLagInformation {
+  private scrape(): EventLoopLagInformation {
     return {
       min: this.checkNan(this._histogram.min / 1e9),
       max: this.checkNan(this._histogram.max / 1e9),

diff --git a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts
@@ -53,7 +53,7 @@ export class EventLoopUtilizationCollector extends BaseCollector {
 
   protected internalEnable(): void {}
 
-  protected scrape(): EventLoopUtilization {
+  private scrape(): EventLoopUtilization {
     return eventLoopUtilizationCollector();
   }
 }
diff --git a/plugins/node/instrumentation-runtime-node/src/metrics/heapSpacesSizeAndUsedCollector.ts b/plugins/node/instrumentation-runtime-node/src/metrics/heapSpacesSizeAndUsedCollector.ts
@@ -124,7 +124,7 @@ export class HeapSpacesSizeAndUsedCollector extends BaseCollector {
 
   internalDisable(): void {}
 
-  protected scrape(): HeapSpaceInfo[] {
+  private scrape(): HeapSpaceInfo[] {
     return v8.getHeapSpaceStatistics();
   }
 }