-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FOSSA license scanning #7090
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7090 +/- ##
============================================
+ Coverage 89.85% 89.86% +0.01%
Complexity 6613 6613
============================================
Files 740 740
Lines 19991 19991
Branches 1966 1966
============================================
+ Hits 17962 17964 +2
+ Misses 1438 1437 -1
+ Partials 591 590 -1 ☔ View full report in Codecov by Sentry. |
|
||
val DEPENDENCIES = listOf( | ||
"org.junit.jupiter:junit-jupiter-api:5.11.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow the armeria pattern and explicitly add dependency versions here for each of the junit components we use? I.e.:
"org.junit.jupiter:junit-jupiter-api:${junitVersion}",
"org.junit.jupiter:junit-jupiter-params:${junitVersion}",
"org.junit.jupiter:junit-jupiter-pioneer:${junitVersion}",
If we can, we should try to retain the pattern of establishing all dependency versions here and not letting the junit dependency version leak into otel-java-conventions.gradle.kts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.