Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate best practices #7069

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

trask
Copy link
Member

@trask trask commented Feb 5, 2025

After this, Renovate should send a PR to start pinning github actions and docker images.

Because of the resulting increase in Renovate PRs for ever github action minor version, I followed the instrumentation repo where we group the updates and limit them to once a week.

Related to #7068

Marked as draft for now because it's better to merge #7074 first.

@trask trask requested a review from a team as a code owner February 5, 2025 21:55
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (9f0a291) to head (60d6370).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7069   +/-   ##
=========================================
  Coverage     89.84%   89.84%           
  Complexity     6610     6610           
=========================================
  Files           740      740           
  Lines         19981    19981           
  Branches       1966     1966           
=========================================
  Hits          17951    17951           
  Misses         1440     1440           
  Partials        590      590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trask trask marked this pull request as draft February 6, 2025 02:05
@@ -1,9 +1,17 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base"
"config:recommended",
"docker:pinDigests",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this answers my other question?

@trask trask marked this pull request as ready for review February 7, 2025 20:26
@trask trask marked this pull request as draft February 7, 2025 20:28
@trask trask marked this pull request as ready for review February 10, 2025 16:54
@jack-berg jack-berg merged commit 768e789 into open-telemetry:main Feb 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants