Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synchronization to SimpleLogRecordProcessor and SimpleSpanProcessor to ensure thread-safe export of logs and spans respectively #6885

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

slodha
Copy link
Contributor

@slodha slodha commented Nov 16, 2024

Resolves #6681

@slodha slodha requested a review from a team as a code owner November 16, 2024 00:15
Copy link

linux-foundation-easycla bot commented Nov 16, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

…or to ensure thread-safe export of logs and spans respectively
@breedx-splk
Copy link
Contributor

Resolves #6681

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (ca98fc5) to head (c56de26).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6885   +/-   ##
=========================================
  Coverage     90.30%   90.31%           
  Complexity     6589     6589           
=========================================
  Files           729      729           
  Lines         19767    19773    +6     
  Branches       1944     1944           
=========================================
+ Hits          17851    17857    +6     
  Misses         1325     1325           
  Partials        591      591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit 2a97eae into open-telemetry:main Nov 18, 2024
25 checks passed
@slodha slodha deleted the slodha.issue-6681 branch November 18, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleLogRecordProcessor, SimpleSpanProcessor call export concurrently, but shouldn't
4 participants