Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set declarative config default OTLP protocol to http/protobuf #6800

Conversation

jack-berg
Copy link
Member

This comment from the code explains the motivation behind this:

NOTE: The default OTLP protocol is different for declarative config than for env var / system property based config. This is intentional. OpenTelemetry changed the default protocol recommendation from grpc to http/protobuf, but the autoconfigure's env var / system property based config did not update to reflect this before stabilizing, and changing is a breaking change requiring a major version bump. Declarative config is not yet stable and therefore can switch to the current default recommendation, which aligns also aligns with the behavior of the OpenTelemetry Java Agent 2.x+.

@jack-berg jack-berg requested a review from a team as a code owner October 16, 2024 22:29
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (537f5c4) to head (a1e5def).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6800      +/-   ##
============================================
- Coverage     90.11%   89.88%   -0.23%     
+ Complexity     6545     6539       -6     
============================================
  Files           728      728              
  Lines         19702    19702              
  Branches       1935     1935              
============================================
- Hits          17755    17710      -45     
- Misses         1347     1390      +43     
- Partials        600      602       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 62df132 into open-telemetry:main Oct 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants