Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Executor for PrometheusHttpServer configurable #5296

Merged

Conversation

abhisesh
Copy link
Contributor

Fixes #5243

@abhisesh abhisesh requested a review from a team March 14, 2023 03:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2b2378e) 90.97% compared to head (08836ab) 90.98%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5296   +/-   ##
=========================================
  Coverage     90.97%   90.98%           
- Complexity     4907     4910    +3     
=========================================
  Files           552      552           
  Lines         14489    14496    +7     
  Branches       1372     1373    +1     
=========================================
+ Hits          13182    13189    +7     
  Misses          907      907           
  Partials        400      400           
Impacted Files Coverage Δ
...etry/exporter/prometheus/PrometheusHttpServer.java 80.73% <100.00%> (ø)
...porter/prometheus/PrometheusHttpServerBuilder.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Thanks!

@jkwatson jkwatson merged commit d95bc83 into open-telemetry:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrometheusHttpServer FixedThreadPool
4 participants