Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support process.runtime.* resource attributes #2143

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Support process.runtime.* resource attributes #2143

merged 3 commits into from
Nov 30, 2020

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #1908

Oberon00
Oberon00 approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's nice: We have both a ResourceProvider and it is included in the default attributes.
The only problem I can see over "hard-coding" this like the telemetry SDK resource, is that the SPI approach might not work with some fat Jar approaches.

...resources/src/main/java/io/opentelemetry/sdk/extension/resources/ProcessRuntimeResource.java Outdated Show resolved Hide resolved
...urces/src/test/java/io/opentelemetry/sdk/extension/resources/ProcessRuntimeResourceTest.java Outdated Show resolved Hide resolved
anuraaga
anuraaga approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

jkwatson
jkwatson approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkwatson jkwatson merged commit 2130644 into open-telemetry:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@jkwatson jkwatson jkwatson approved these changes

@arminru arminru Awaiting requested review from arminru

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@thisthat thisthat Awaiting requested review from thisthat

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support process.runtime.* resource attributes
4 participants
@mateuszrzeszutek @anuraaga @Oberon00 @jkwatson