Removed responseBody() call in HttpExporter to allow clients to con…

…sume it via FailedExportException
open-telemetry · Aug 22, 2024 · b5557f4 · b5557f4
1 parent 033e919
commit b5557f4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 28 deletions.
diff --git a/exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporter.java b/exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporter.java
@@ -8,16 +8,13 @@
 import io.opentelemetry.api.metrics.MeterProvider;
 import io.opentelemetry.exporter.internal.ExporterMetrics;
 import io.opentelemetry.exporter.internal.FailedExportException;
-import io.opentelemetry.exporter.internal.grpc.GrpcExporterUtil;
 import io.opentelemetry.exporter.internal.marshal.Marshaler;
 import io.opentelemetry.sdk.common.CompletableResultCode;
 import io.opentelemetry.sdk.internal.ThrottlingLogger;
-import java.io.IOException;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Supplier;
 import java.util.logging.Level;
 import java.util.logging.Logger;
-import javax.annotation.Nullable;
 
 /**
  * An exporter for http/protobuf or http/json using a signal-specific Marshaler.
@@ -74,23 +71,13 @@ public CompletableResultCode export(T exportRequest, int numItems) {
 
           exporterMetrics.addFailed(numItems);
 
-          byte[] body = null;
-          try {
-            body = httpResponse.responseBody();
-          } catch (IOException ex) {
-            logger.log(Level.FINE, "Unable to obtain response body", ex);
-          }
-
-          String status = extractErrorStatus(httpResponse.statusMessage(), body);
-
           logger.log(
               Level.WARNING,
               "Failed to export "
                   + type
                   + "s. Server responded with HTTP status code "
                   + statusCode
-                  + ". Error message: "
-                  + status);
+                  + ".");
 
           result.failExceptionally(FailedExportException.httpFailedWithResponse(httpResponse));
         },
@@ -116,15 +103,4 @@ public CompletableResultCode shutdown() {
     }
     return httpSender.shutdown();
   }
-
-  private static String extractErrorStatus(String statusMessage, @Nullable byte[] responseBody) {
-    if (responseBody == null) {
-      return "Response body missing, HTTP status message: " + statusMessage;
-    }
-    try {
-      return GrpcExporterUtil.getStatusMessage(responseBody);
-    } catch (IOException e) {
-      return "Unable to parse response body, HTTP status message: " + statusMessage;
-    }
-  }
 }
diff --git a/...va/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java b/...va/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java
@@ -632,9 +632,7 @@ void error() {
 
     LoggingEvent log =
         logs.assertContains(
-            "Failed to export "
-                + type
-                + "s. Server responded with HTTP status code 500. Error message:");
+            "Failed to export " + type + "s. Server responded with HTTP status code 500.");
     assertThat(log.getLevel()).isEqualTo(Level.WARN);
   }