Add smoke test for the OTel Spring starter #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,6 +132,8 @@ hideFromDependabot(":smoke-tests:images:servlet:servlet-3.0") | |||
| hideFromDependabot(":smoke-tests:images:servlet:servlet-5.0") | |||
| hideFromDependabot(":smoke-tests:images:spring-boot") | |||
|
|
|||
| include(":smoke-tests-otel-starter") | |||
There was a problem hiding this comment.
Do we want dependabot to update e.g. h2 or dbcp2 versions?
Suggested change
| include(":smoke-tests-otel-starter") | |
| hideFromDependabot(":smoke-tests-otel-starter") |
Also, WDYT about using e.g.
Suggested change
| include(":smoke-tests-otel-starter") | |
| include(":smoke-tests:spring-starter-smoke-test") |
? I'm trying to avoid exploding the number of directories in the root repo dir, we could put all smoke tests projects into smoke-test
There was a problem hiding this comment.
hideFromDependabot is commited.
The smoke-tests folder contains a lot of code related to the agent smoke tests. I would suggest a clear separation between the agent smoke test code and the Spring starter smoke test code.
Perhaps after this PR, a refactoring could add agent-smoke-tests and spring-starter-smoke-tests subfolders into the smoke-tests folder to:
- Separate the two smoke test codes (agent smoke test and Spring starter smoke test)
- Make the namings explicit (agent smoke test and Spring starter smoke test)
- Limit the number of second-level folders
...-tests-otel-starter/src/test/java/io/opentelemetry/smoketest/OtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
...-tests-otel-starter/src/test/java/io/opentelemetry/smoketest/OtelSpringStarterSmokeTest.java
Show resolved
Hide resolved
...-tests-otel-starter/src/test/java/io/opentelemetry/smoketest/OtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
trask
approved these changes
Jul 20, 2023
...r/src/main/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTestApplication.java
Outdated
Show resolved
Hide resolved
smoke-tests-otel-starter/src/main/java/io/opentelemetry/spring/smoketest/SqlExecutor.java
Outdated
Show resolved
Hide resolved
...-tests-otel-starter/src/test/java/io/opentelemetry/smoketest/OtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <[email protected]>
…/smoketest/SqlExecutor.java Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a smoke test for the OTel Spring starter with library instrumentations, as discussed in #8776 and during Java SIG.
The test checks the presence of an HTTP span, an SQL span, a Logback log record, and a histogram metric.
The smoke test can be executed in a JVM or as a GraalVM native test. It will be part of the daily native test executions.