Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new properties #6633

Merged
merged 2 commits into from
Sep 18, 2022
Merged

Fix new properties #6633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
761f46e
Fix new properties
trask Sep 15, 2022
58d9bc9
Merge branch 'main' into HEAD
laurit Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...rc/main/java/io/opentelemetry/javaagent/instrumentation/quartz/v2_0/QuartzSingletons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
package io.opentelemetry.javaagent.instrumentation.quartz.v2_0;

import io.opentelemetry.api.GlobalOpenTelemetry;
import io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil;
import io.opentelemetry.instrumentation.quartz.v2_0.QuartzTelemetry;
import io.opentelemetry.javaagent.bootstrap.internal.InstrumentationConfig;

public final class QuartzSingletons {

public static final QuartzTelemetry TELEMETRY =
QuartzTelemetry.builder(GlobalOpenTelemetry.get())
.setCaptureExperimentalSpanAttributes(
ConfigPropertiesUtil.getBoolean(
"otel.instrumentation.quartz.experimental-span-attributes", false))
InstrumentationConfig.get()
.getBoolean("otel.instrumentation.quartz.experimental-span-attributes", false))
.build();

private QuartzSingletons() {}
Expand Down
6 changes: 3 additions & 3 deletions .../main/java/io/opentelemetry/javaagent/instrumentation/spring/batch/job/JobSingletons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
import io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder;
import io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil;
import io.opentelemetry.javaagent.bootstrap.internal.InstrumentationConfig;
import org.springframework.batch.core.JobExecution;

public class JobSingletons {

private static final boolean CAPTURE_EXPERIMENTAL_SPAN_ATTRIBUTES =
ConfigPropertiesUtil.getBoolean(
"otel.instrumentation.spring-batch.experimental-span-attributes", false);
InstrumentationConfig.get()
.getBoolean("otel.instrumentation.spring-batch.experimental-span-attributes", false);

private static final Instrumenter<JobExecution, Void> INSTRUMENTER;

Expand Down
6 changes: 3 additions & 3 deletions ...opentelemetry/javaagent/instrumentation/spring/scheduling/SpringSchedulingSingletons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
import io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder;
import io.opentelemetry.instrumentation.api.instrumenter.code.CodeAttributesExtractor;
import io.opentelemetry.instrumentation.api.instrumenter.code.CodeSpanNameExtractor;
import io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil;
import io.opentelemetry.javaagent.bootstrap.internal.InstrumentationConfig;

public final class SpringSchedulingSingletons {

private static final boolean CAPTURE_EXPERIMENTAL_SPAN_ATTRIBUTES =
ConfigPropertiesUtil.getBoolean(
"otel.instrumentation.spring-scheduling.experimental-span-attributes", false);
InstrumentationConfig.get()
.getBoolean("otel.instrumentation.spring-scheduling.experimental-span-attributes", false);

private static final Instrumenter<Runnable, Void> INSTRUMENTER;

Expand Down