Fixed dropwizard and netty test issues #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydin
requested review from
jkwatson,
safris,
trask and
tylerbenson
as code owners
trask
reviewed
Jan 15, 2020
| @@ -61,7 +61,7 @@ class Netty40ClientTest extends HttpClientTest<NettyHttpClientDecorator> { | |||
|
|
|||
| def "connection error (unopened port)"() { | |||
| given: | |||
| def uri = new URI("http://localhost:$UNUSABLE_PORT/") | |||
| def uri = new URI("http://127.0.0.1:$UNUSABLE_PORT/") // Use numeric address to avoid ipv4/ipv6 confusion | |||
| @@ -71,6 +71,7 @@ class Netty40ClientTest extends HttpClientTest<NettyHttpClientDecorator> { | |||
| then: | |||
| def ex = thrown(Exception) | |||
| def thrownException = ex instanceof ExecutionException ? ex.cause : ex | |||
| println "Exception: $ex" | |||
There was a problem hiding this comment.
Just checking if this was an artifact of debugging, or intentionally part of PR, I'm ok either way
There was a problem hiding this comment.
This is leftover debugging. I'll get rid of it.
| def testSupport = new DropwizardTestSupport(testApp(), | ||
| null, | ||
| ConfigOverride.config("server.applicationConnectors[0].port", "$port")) | ||
| ConfigOverride.config("server.applicationConnectors[0].port", "$port"), | ||
| ConfigOverride.config("server.adminConnectors[0].port", "" + PortUtils.randomOpenPort())) |
There was a problem hiding this comment.
The check build failed, flagging this line, see https://829-210933087-gh.circle-artifacts.com/0/home/circleci/dd-trace-java/reports/java-agent/instrumentation/dropwizard/codenarc/test.html
There was a problem hiding this comment.
OK. That's a lazy way of making a string from an int. Not that it matters in this context, but we want clean builds, so I'll change it!
tylerbenson
approved these changes
Jan 16, 2020
|
Will do as soon as I’m back to my laptop. |
|
That ended up being a really messy merge... :( Lots of rename and add conflicts. I may just isolate my changes and issue a new PR against master instead. |
|
Sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #58 (Dropwizard fails when port 9091 is used)
Fixed #59 (netty test fails when connecting over ipv6)