Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Netty 4.1 spans after response has completed not when it started. #2641

Merged
merged 5 commits into from
Mar 27, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update instrumentation/netty/netty-4.1/javaagent/src/main/java/io/ope…
…ntelemetry/javaagent/instrumentation/netty/v4_1/server/HttpServerResponseTracingHandler.java

Co-authored-by: Trask Stalnaker <[email protected]>
  • Loading branch information
Anuraag Agrawal and trask authored Mar 27, 2021
commit bbdab4a8163db100975bfb929fe4d08a0cfe797b
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise prm) {
final ChannelPromise writePromise;

if (msg instanceof LastHttpContent) {
if (prm == ctx.voidPromise()) {
if (prm.isVoid()) {
// Some frameworks don't actually listen for response completion and optimize for
// allocations by using a singleton, unnotifiable promise. Hopefully these frameworks don't
// have observability features or they'd be way off...
Expand Down