Implementing ExtendedTextMapGetter in grpc-1.6 instrumentation
#13011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiepuhuan <[email protected]>
|
Do I need to add unit testing to |
trask
reviewed
Jan 7, 2025
...-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcRequestGetter.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Jan 8, 2025
jamesmoessis
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Nice work @xiepuhuan
I'm not overly familiar with the gRPC library, but this looks good to me. A unit test would give further confidence that multi-extraction is working. However if it has @trask's approval without the extra test I assume it's ok :)
laurit
approved these changes
Jan 8, 2025
I opened #13016 to track this, @xiepuhuan wdyt? |
I will complete it immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12868