Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit dynamic assigner #12049

Closed

Conversation

SylvainJuge
Copy link
Contributor

@SylvainJuge SylvainJuge commented Aug 19, 2024

Follow-up of #11884

We can now remove most (but not all) usages of typing = typing = Typing.DYNAMIC as it is now the default thanks to #11884

@SylvainJuge
Copy link
Contributor Author

Closing as removing those leads to other complications which make it not worth to invest for now (thanks @JonasKunz for the investigation) :

  • when testing with indy, there is the error java.lang.IllegalStateException: Cannot assign void to class java.lang.Object. This happens if you use Advice.Return with non-DYNAMIC typing while instrumenting void types. Dynamic typing seems to take care of this and to assign null in that case.
  • when testing with non-indy, there are problems with advice paramters with readonly=false: Because then the assignment also happens in the other direction, causing static typing to fail

@SylvainJuge SylvainJuge deleted the remove-dynamic-assigner branch August 21, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant