Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public suffixes list from the agent #10763

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove public suffixes list from the agent #10763

merged 1 commit into from
Dec 4, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Mar 5, 2024

Resolves #10705

@laurit laurit requested a review from a team March 5, 2024 15:52
@laurit
Copy link
Contributor Author

laurit commented Mar 5, 2024

@trask could you see whether this makes sense

@laurit laurit changed the title Remove public suffixes data from the agent Remove public suffixes list from the agent Mar 5, 2024
@trask
Copy link
Member

trask commented Mar 5, 2024

I'd suggest holding off on this a bit, at least until we decide whether we need to apply for an exception for SDK anyways: #10705 (comment)

trask
trask approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @laurit, I'm going to go ahead and merge this ❤️

@trask trask merged commit 7b69e56 into open-telemetry:main Dec 4, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitlinger zeitlinger zeitlinger approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License Scan/Remediation Questions
3 participants
@laurit @trask @zeitlinger