-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeze structs/arrays; disallow multidimensional arrays #950
Conversation
Hm, open-telemetry/opentelemetry-proto#157 says that yes, OTLP does intend to support nested arrays (even though the spec itself is silent on whether nested arrays are allowed). Let me rethink my approach here... |
open-telemetry/opentelemetry-specification#596 says at the moment we are not required to support nested arrays. Out of simplicity, until that PR is passed, I think we should not support nested arrays, then :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the related spec issue closed with no change, meaning the single dimensionality is the current expected behavior.
@lizthegrey I think this can be merged if you can clean up the conflicts. I tried myself, but it looks like contributions from maintainers is turned off for this source. |
Great, sorry about the delay, I'll get to it this week. |
We talked about this PR today at the Go SIG meeting and we're wondering @lizthegrey if you need someone to take over this work? Additionally, there were questions about the support of slices. Currently all the methods are named and work with arrays. This is a useful format to store the data in as it is very optimized for storage, but it is not the common type used. Instead, commonly slices are the type used and if we are returning an array (each a distinct type for each length of the array) users cannot handle these values in a generalized way. I.e. they cannot pass the return value to a function as the function needs to be defined to support all the types each array could be, instead they will need to convert the array back to a slice. It seems like we might provide a better API if we support this by default. |
Yeah, go ahead and take it over. I'm almost done moving but not quite yet set up. |
See #949 and open-telemetry/opentelemetry-specification#376 (comment)