-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split metric configuration down to instrument #3895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3895 +/- ##
=======================================
+ Coverage 81.6% 81.8% +0.1%
=======================================
Files 169 169
Lines 12711 12855 +144
=======================================
+ Hits 10375 10517 +142
- Misses 2117 2119 +2
Partials 219 219
|
MrAlias
force-pushed
the
per-inst-config
branch
from
March 16, 2023 16:07
2a1ca2a
to
f2f4235
Compare
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
March 16, 2023 16:18
MrAlias
added
pkg:API
Related to an API package
area:metrics
Part of OpenTelemetry Metrics
labels
Mar 16, 2023
This comment was marked as resolved.
This comment was marked as resolved.
pellared
approved these changes
Mar 20, 2023
dmathieu
approved these changes
Mar 21, 2023
MadVikingGod
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3889
Resolves #3872
In order to ensure forward compatibility with fine-grain configuration of each instrument, split the instrument configuration to be per instrument.