Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Reimplement OpenCensus bridge #3093

Closed
wants to merge 1 commit into from

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Aug 16, 2022

@dashpole dashpole marked this pull request as draft August 16, 2022 04:26
@dashpole dashpole changed the title [WIP] Reimplement oc bridge [WIP] Reimplement OpenCensus bridge Aug 16, 2022
@dashpole dashpole force-pushed the reimplement_oc_bridge branch 3 times, most recently from ccae2d5 to 09c8bb7 Compare August 17, 2022 16:18
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #3093 (70185b3) into main (d7bfe66) will decrease coverage by 0.0%.
The diff coverage is 58.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3093     +/-   ##
=======================================
- Coverage   77.3%   77.2%   -0.1%     
=======================================
  Files        159     160      +1     
  Lines      11139   11178     +39     
=======================================
+ Hits        8613    8638     +25     
- Misses      2329    2342     +13     
- Partials     197     198      +1     
Impacted Files Coverage Δ
sdk/metric/config.go 91.0% <16.6%> (-9.0%) ⬇️
sdk/metric/pipeline.go 91.0% <27.7%> (-6.3%) ⬇️
bridge/opencensus/metric.go 45.1% <100.0%> (+45.1%) ⬆️
bridge/opencensus/version.go 100.0% <100.0%> (ø)
sdk/metric/provider.go 100.0% <100.0%> (ø)
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias added pkg:bridges Related to a bridge package area:metrics Part of OpenTelemetry Metrics labels Aug 17, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Aug 17, 2022
@dashpole dashpole changed the title [WIP] Reimplement OpenCensus bridge [PoC] Reimplement OpenCensus bridge Aug 18, 2022
@dashpole dashpole force-pushed the reimplement_oc_bridge branch 3 times, most recently from e7617f9 to 95e8f3a Compare August 18, 2022 21:09
@MrAlias MrAlias changed the base branch from new_sdk/main to main September 16, 2022 14:36
@dashpole dashpole force-pushed the reimplement_oc_bridge branch 4 times, most recently from 066ecb2 to e4e15b4 Compare September 22, 2022 20:11
@dashpole dashpole force-pushed the reimplement_oc_bridge branch 3 times, most recently from 78822b1 to 3c8e3c9 Compare September 22, 2022 20:20
@dashpole dashpole force-pushed the reimplement_oc_bridge branch from 3c8e3c9 to 70185b3 Compare September 22, 2022 20:25
@dashpole
Copy link
Contributor Author

This is now rebased on main (from the new_sdk/main branch)

@MrAlias MrAlias removed this from the Metric SDK: Beta milestone Oct 14, 2022
@dashpole dashpole closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:bridges Related to a bridge package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back the OpenCensus bridge code
2 participants