Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Attributes to Instrumentation Scope #2884

Closed
wants to merge 1 commit into from
Closed

Add Attributes to Instrumentation Scope #2884

wants to merge 1 commit into from

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented May 2, 2022 •
edited
Loading

This is not a full prototype, but just a very quick illustration of a possible approach that adds WithScopeAttributes option to the Tracer.

This is not intended to be reviewed in details or to be merged. The only purpose of this PR is to facilitate the discussion of OTEP: open-telemetry/oteps#201

@tigrannajaryan tigrannajaryan mentioned this pull request May 2, 2022
Merged
MrAlias
MrAlias reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a viable approach and I think the OTEP can be considered implementable in Go. 👍

@tigrannajaryan
Copy link
Member Author

Closing. The PR served its purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias left review comments

@XSAM XSAM Awaiting requested review from XSAM XSAM will be requested when the pull request is marked ready for review XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole will be requested when the pull request is marked ready for review dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared will be requested when the pull request is marked ready for review pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu will be requested when the pull request is marked ready for review dmathieu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tigrannajaryan @MrAlias