-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Go versions that contain GOEXPERIMENT
suffixes.
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry for this.
842adf6
to
ca14289
Compare
@MrAlias PTAL. |
MrAlias
reviewed
Oct 19, 2023
Signed-off-by: Koichi Shiraishi <[email protected]>
ca14289
to
dc4beee
Compare
@MrAlias PTALA. |
GOEXPERIMENT
suffixes.
MrAlias
reviewed
Oct 20, 2023
MrAlias
approved these changes
Oct 20, 2023
Merged
seems this fix is reverted in v0.12.0-alpha seeing the following error from GOEXPERIMENT "nocoverageredesign"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim the
X:...
suffix when any GOEXPERIMENT is enabled.Currently, can't parse the Go version if the target Go binary enables any
GOEXPERIMENT
. Seems thathashicorp/go-version
doesn't support it.When if enable
arenas
GOEXPERIMENT, the error message is here:Trim
X:
(note that started one space) before passingvers
toversion.NewVersion
.This package hasn't a test case but confirmed at least my GKE cluster.