Remove path from HTTP instrumentation span name. #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
http-span-names
branch
2 times, most recently
from
7b485e6 to
f9281c9
Compare
Only use the method name because the path is likely going to have a high cardinality.
MrAlias
changed the title
edeNFed
approved these changes
May 18, 2023
pellared
reviewed
May 18, 2023
Co-authored-by: Robert Pająk <[email protected]>
pdelewski
approved these changes
May 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
Currently the path is included in HTTP instrumentation span names. This is a high-cardinality value and not specification compliant. It is removed from the span name in this PR.
Note that in both the gin and mux frameworks there are low-cardinality templatized path. However, they are not available from the places were currently instrument. Further investigation is needed to determine if there are better places we can instrument or access these templatized paths.