Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: only start span if not filtered out #6695

Merged
merged 15 commits into from
Jan 30, 2025

Conversation

vianamjr
Copy link
Contributor

Related to #6446

Only start a span if it's not filtered out.

@vianamjr vianamjr requested review from dashpole and a team as code owners January 29, 2025 15:15
@dmathieu
Copy link
Member

Have you looked into adding a test?

@vianamjr
Copy link
Contributor Author

@dmathieu I will look into soon, Just need to test is a bit more in a specific env and will come with tests.

@vianamjr
Copy link
Contributor Author

Kind of trick to add tests, but I could do it. (I hope)

@vianamjr
Copy link
Contributor Author

Not sure If there is something missing regarding the review, let me know.

@dmathieu
Copy link
Member

Could you look into the test suite failures?

@vianamjr
Copy link
Contributor Author

Could you look into the test suite failures?

Sure, my mistake, fixed, I hope now it's ok

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1%. Comparing base (6eaddb9) to head (7f41c5d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6695   +/-   ##
=====================================
  Coverage   73.1%   73.1%           
=====================================
  Files        191     191           
  Lines      15858   15866    +8     
=====================================
+ Hits       11598   11606    +8     
  Misses      3925    3925           
  Partials     335     335           
Files with missing lines Coverage Δ
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 100.0% <100.0%> (ø)

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Damien Mathieu <[email protected]>
@MrAlias
Copy link
Contributor

MrAlias commented Jan 30, 2025

@dashpole does this look good to you?

@dashpole
Copy link
Contributor

yep

@MrAlias MrAlias merged commit c2d95c6 into open-telemetry:main Jan 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants