Add initial Codeowners file #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Clawson <[email protected]>
MadVikingGod
added
the
Skip Changelog
MrAlias
requested changes
Nov 29, 2022
There was a problem hiding this comment.
There is already a CODEOWNERS file at the top level: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/6172b243ea492c711fbd2de93935d2e76aa2362d/CODEOWNERS
We need to unify that and this.
dashpole
reviewed
Nov 29, 2022
MrAlias
reviewed
Nov 29, 2022
MrAlias
reviewed
Nov 29, 2022
MrAlias
reviewed
Nov 29, 2022
Aneurysm9
reviewed
Nov 29, 2022
.github/CODEOWNERS
Outdated
| samplers/jaegerremote/ @open-telemetry/go-approvers | ||
| samplers/probability/consistent/ @open-telemetry/go-approvers | ||
|
|
||
| zpages/ @open-telemetry/go-approvers |
There was a problem hiding this comment.
Suggested change
| zpages/ @open-telemetry/go-approvers | |
| zpages/ @open-telemetry/go-approvers @open-telemetry/collector-maintainers |
cc @open-telemetry/collector-maintainers
MadVikingGod
commented
Nov 29, 2022
MrAlias
approved these changes
Nov 29, 2022
dmathieu
reviewed
Nov 29, 2022
Co-authored-by: Damien Mathieu <[email protected]>
MrAlias
reviewed
Dec 1, 2022
MrAlias
reviewed
Dec 15, 2022
There was a problem hiding this comment.
@MadVikingGod plans to identify authors of un-owned packages and ping them here.
hanyuancheung
approved these changes
Dec 16, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3045 +/- ##
=====================================
Coverage 69.6% 69.6%
=====================================
Files 147 147
Lines 6919 6919
=====================================
+ Hits 4818 4821 +3
+ Misses 1980 1978 -2
+ Partials 121 120 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of #2834.
This only adds the current go-approvers for ownership of all parts of the contrib. If we merge this, ownership can be declared by PR to this file.