Skip to content

Commit

Permalink
Remove the instrgen module (#6671)
Browse files Browse the repository at this point in the history
Co-authored-by: Robert Pająk <[email protected]>
  • Loading branch information
MrAlias and pellared authored Jan 23, 2025
1 parent 0746da0 commit 7d7606c
Show file tree
Hide file tree
Showing 48 changed files with 2 additions and 2,696 deletions.
29 changes: 0 additions & 29 deletions .github/ISSUE_TEMPLATE/bug_report_instrgen.md

This file was deleted.

30 changes: 0 additions & 30 deletions .github/ISSUE_TEMPLATE/feature_request_instrgen.md

This file was deleted.

2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,4 @@ examples/zipkin/zipkin
instrumentation/google.golang.org/grpc/otelgrpc/example/server/server
instrumentation/google.golang.org/grpc/otelgrpc/example/client/client

instrgen/driver/testdata/**/*.go_pass_*

tmp
1 change: 0 additions & 1 deletion CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,3 @@ samplers/jaegerremote/ @open-te
samplers/probability/consistent/ @open-telemetry/go-approvers

zpages/ @open-telemetry/go-approvers @dashpole
instrgen/ @open-telemetry/go-approvers @open-telemetry/go-instrumentation-approvers @MrAlias @pdelewski
8 changes: 2 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,25 +88,21 @@ Changes should be made using [the GitHub flow](https://guides.github.com/introdu

A pull request is considered ready to merge when the following criteria are meet.

* It has received two approvals from Code Owners/Approvers/Maintainers (at different companies), unless the change is for an exempt module[^1].
* It has received two approvals from Code Owners/Approvers/Maintainers (at different companies).
* All feedback has been addressed. Be sure to "Resolve" all comments that have been addressed to signal this.
* Any substantive changes submitted after an Approval removes that Approval.
You will need to manually clear these prior Approval reviews to indicate to the reviewer that they need to resubmit their review.
This includes changes resulting from other feedback.
Unless the approver explicitly stated that their approval will persist across changes it should be assumed that the pull request needs their review again.
Other project members (e.g. approvers, maintainers) can help with this if there are any questions or if you forget to clear reviews.
* If the changes are not trivial, cosmetic, exempt[^1], or for documentation or dependencies only, the pull request will need to be open for review for at least one working day.
* If the changes are not trivial, cosmetic, exempt, or for documentation or dependencies only, the pull request will need to be open for review for at least one working day.
This gives people reasonable time to review.
* `CHANGELOG.md` has been updated to reflect what has been added, changed, removed, or fixed from the end users perspective.
See [how to keep a changelog](https://keepachangelog.com/en/1.0.0/).
* Urgent fixes can take exception as long as it has been actively communicated.

Any Maintainer can merge the pull request once it is ready to merge.

[^1]: The `go.opentelemetry.io/contrib/instrgen` module is exempt from the two approvals and one day requirement.
Only one approval is needed to merge a Pull Request for that module and there is no minimum amount of time required for the PR to be open before merging.
This exemption is to be removed when that package makes its first tagged release.

### Draft Pull Requests

It can be helpful at times to publish your incomplete changes.
Expand Down
40 changes: 0 additions & 40 deletions instrgen/README.md

This file was deleted.

8 changes: 0 additions & 8 deletions instrgen/doc.go

This file was deleted.

Binary file removed instrgen/docs/flow.png
Binary file not shown.
12 changes: 0 additions & 12 deletions instrgen/docs/how-it-works.md

This file was deleted.

19 changes: 0 additions & 19 deletions instrgen/driver/go.mod

This file was deleted.

18 changes: 0 additions & 18 deletions instrgen/driver/go.sum

This file was deleted.

106 changes: 0 additions & 106 deletions instrgen/driver/instrgen_test.go

This file was deleted.

Loading

0 comments on commit 7d7606c

Please sign in to comment.