Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs to *_processor modules #675

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

whatyouhide
Copy link
Contributor

@whatyouhide whatyouhide commented Jan 22, 2024

This is work that I quickly chatter about with @tsloughter.

@whatyouhide whatyouhide requested a review from a team January 22, 2024 11:13
Copy link

linux-foundation-easycla bot commented Jan 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: whatyouhide / name: Andrea Leopardi (d5fe7e0)
  • ✅ login: tsloughter / name: Tristan Sloughter (ce08c3c)

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05a7704) 74.35% compared to head (d5fe7e0) 74.35%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   74.35%   74.35%           
=======================================
  Files          56       56           
  Lines        1852     1852           
=======================================
  Hits         1377     1377           
  Misses        475      475           
Flag Coverage Δ
api 73.14% <ø> (ø)
erlang 74.35% <ø> (ø)
exporter 67.47% <ø> (ø)
sdk 78.69% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes are clearly unrelated to the CI failures, these are decent improvements.

@whatyouhide whatyouhide changed the title Add docs to *_processor modules Add docs to *_processor modules Feb 4, 2024
@tsloughter tsloughter merged commit a53ff15 into open-telemetry:main Feb 6, 2024
11 of 13 checks passed
@whatyouhide whatyouhide deleted the al/span-docs branch February 6, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants