Configuration improvements and span limit settings #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 6, 2021 16:05
these changes ensure all configuration goes through transform checks to verify their type, as best we can. Before only the values from OS environment variables would be transformed. This could lead to configuration values like "string" for a key like attribute_count_limit that requires an integer.
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 38.47% 38.49% +0.01%
==========================================
Files 50 51 +1
Lines 3462 3510 +48
==========================================
+ Hits 1332 1351 +19
- Misses 2130 2159 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ferd
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For span limits this only has the record and sets it to a persistent term through the application environment or OS environment configuration.
Once I realized I wanted to improve the configuration I stopped at that point to open a PR and then will follow it up with one that actually utilizes the span limits.
Two main issues were resolved with the configuration updates here: first, it will now fall back to the default value if transforming the user supplied value fails, and second, application environment configuration values are transformed as well, so setting a string for a limit in the application environment will fallback to the default as well.