Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.Extensions.Logging to net8 #4920

Merged
merged 13 commits into from
Oct 6, 2023
Merged

Bump Microsoft.Extensions.Logging to net8 #4920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
736f71a
bump Microsoft.Extensions.Logging and dependencies to net8
reyang Oct 5, 2023
8686020
fix build
reyang Oct 5, 2023
78ac33e
reduce build error
reyang Oct 5, 2023
9b3d2b5
fix build
reyang Oct 5, 2023
9ac3ea9
reduce build warning
reyang Oct 5, 2023
f02f429
version
reyang Oct 5, 2023
8cd3858
nit
reyang Oct 5, 2023
4bcb1d5
changelog
reyang Oct 5, 2023
f3c4c1b
Update Directory.Packages.props
reyang Oct 5, 2023
31c857a
reduce changes
reyang Oct 5, 2023
f20e325
Merge branch 'main' into reyang/ilogger-version
reyang Oct 5, 2023
f36b235
Merge branch 'main' into reyang/ilogger-version
reyang Oct 6, 2023
842ca30
revert changelog edits
reyang Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,17 @@
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="[3.1.0,)" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="[3.1.0,)" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="[2.1.0,)" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="[3.1.0,)" />

<!--
Typically, the latest stable version of Microsoft.Extensions.Logging should be used here because:
1) Each major version bump will have some new API capabilities (e.g. .NET 6 introduced compile-time logging
source generation, .NET 8 introduced automatic event id generation).
2) Each minor version bump is normally security hotfixes or critical bug fixes.
3) Since version 3.1.0, the .NET runtime team is holding a high bar for backward compatibility on
Microsoft.Extensions.Logging even during major version bumps, so compatibility is not a concern here.
-->
<PackageVersion Include="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23419.4" />
cijothomas marked this conversation as resolved.
Show resolved Hide resolved
CodeBlanch marked this conversation as resolved.
Show resolved Hide resolved

<PackageVersion Include="Microsoft.Extensions.Logging.Configuration" Version="[3.1.0,)" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="[3.1.0,)" />
<PackageVersion Include="OpenTelemetry" Version="$(OTelLatestStableVer)" />
Expand Down
3 changes: 0 additions & 3 deletions docs/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Packages.props, $(MSBuildThisFileDirectory)..))" />
cijothomas marked this conversation as resolved.
Show resolved Hide resolved
<ItemGroup>
<PackageVersion Update="Microsoft.Extensions.Logging" Version="[6.0.0,)" />
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion examples/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Packages.props, $(MSBuildThisFileDirectory)..))" />
<ItemGroup>
<PackageVersion Update="Microsoft.Extensions.Logging" Version="[6.0.0,)" />
<PackageVersion Update="System.Text.Json" Version="6.0.5" />
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion test/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Packages.props, $(MSBuildThisFileDirectory)..))" />
<ItemGroup>
<PackageVersion Update="Microsoft.Extensions.Logging" Version="[6.0.0,)" />
<PackageVersion Update="System.Text.Json" Version="6.0.5" />
</ItemGroup>
</Project>