Add configuration of persistent storage to OTLP Exporter #4251

mic-max · 2023-03-02T00:09:51Z

Towards #4115

Changes

Adds PersistentBlobProvider to Base OTLP gRPC Export Client that does nothing currently. Added a TODO which will be updated to conditionally write to disk retryable errors to be done in the next PR.
Update console example program to use it
Note: Only adding via the extension method, not from the OtlpExporter ctor

Screenshot showing OTLP example program running and the file it creates.

commit 080927d Author: Cijo Thomas <[email protected]> Date: Thu Sep 23 10:07:05 2021 -0700 Changelog update for 1.2.0.alpha4 (#2407) commit 61aaf2e Author: Reiley Yang <[email protected]> Date: Thu Sep 23 09:37:18 2021 -0700 Simplify tutorials (#2406) commit 78baf7c Author: Reiley Yang <[email protected]> Date: Thu Sep 23 08:02:09 2021 -0700 Implement the metrics dispose/shutdown logic (#2404) commit 256fc2d Author: Michael Maxwell <[email protected]> Date: Wed Sep 22 17:35:15 2021 -0400 Use `Stopwatch.StartNew()` (#2403)

…her.cs yes thank you, good catch Co-authored-by: Robert Pająk <[email protected]>

cijothomas · 2023-03-06T16:35:51Z

...Telemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj

@@ -19,6 +19,7 @@
    <PackageReference Include="Grpc" Version="$(GrpcPkgVer)" Condition="'$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'net462'" />
    <PackageReference Include="Google.Protobuf" Version="$(GoogleProtobufPkgVer)" />
    <PackageReference Include="Grpc.Tools" Version="$(GrpcToolsPkgVer)" PrivateAssets="all" />
+    <PackageReference Include="OpenTelemetry.Extensions.PersistentStorage.Abstractions" Version="$(PersistentStoragePkgVer)" />


we need to find alternate ways to achieve this. This dependency is unlikely to be accepted for this component, as we have strict 1.5 timeline (when this component need to ship stable) and cannot be blocked as this dependency is a beta component.

We should be able to ship stable version for the abstractions before that. Just need to rename the package
#3469

Should the main/core/SDK package really on the contrib package?

This was discussed in the SIG meeting yesterday, and the general consensus is not to have this dependency.
It could be a separate OTLPWithPersistence package that does this and internally using/overriding the main OTLP Exporter.
Or
OTLP Exporter could expose some general purpose callbacks which can be leveraged by the OTLPWithPersistence package.

…max/opentelemetry-dotnet into otld-persist-failed-exports

….Tests.csproj

codecov · 2023-03-07T00:22:16Z

Codecov Report

Merging #4251 (095dad7) into main (8cd0ef5) will increase coverage by 1.10%.
The diff coverage is 77.77%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4251      +/-   ##
==========================================
+ Coverage   83.15%   84.26%   +1.10%     
==========================================
  Files         296      297       +1     
  Lines       11775    11818      +43     
==========================================
+ Hits         9792     9958     +166     
+ Misses       1983     1860     -123

Impacted Files	Coverage Δ
.../OpenTelemetry/Logs/OpenTelemetryLoggerProvider.cs	`90.90% <50.00%> (-0.85%)`	⬇️
src/OpenTelemetry/ProviderExtensions.cs	`95.00% <50.00%> (-5.00%)`	⬇️
...ge/OtlpTraceExporterPersistentStorageExtensions.cs	`57.89% <57.89%> (ø)`
...mentation/ExportClient/BaseOtlpGrpcExportClient.cs	`85.71% <100.00%> (+1.50%)`	⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs	`93.75% <100.00%> (+0.89%)`	⬆️
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs	`96.42% <100.00%> (+0.06%)`	⬆️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs	`98.41% <100.00%> (+1.74%)`	⬆️
src/OpenTelemetry/Resources/ResourceBuilder.cs	`91.52% <100.00%> (+1.72%)`	⬆️
...enTelemetry/Resources/ResourceBuilderExtensions.cs	`92.85% <100.00%> (ø)`
...Telemetry/Metrics/MetricPointOptionalComponents.cs	`80.00% <0.00%> (-20.00%)`	⬇️
... and 12 more

…max/opentelemetry-dotnet into otld-persist-failed-exports

...rter.OpenTelemetryProtocol.PersistentStorage/OtlpTraceExporterPersistentStorageExtensions.cs

github-actions · 2023-03-16T03:17:10Z

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

github-actions · 2023-03-24T03:17:09Z

Closed as inactive. Feel free to reopen if this PR is still being worked on.

mic-max and others added 30 commits September 23, 2021 14:10

Merge remote-tracking branch 'upstream/main' into main

e51aca6

Merge remote-tracking branch 'upstream/main' into main

3d15631

Merge remote-tracking branch 'upstream/main' into main

472eabb

Merge remote-tracking branch 'upstream/main'

4295758

Merge remote-tracking branch 'upstream/main'

4de8d0f

Guard Type summary comment fix

ccd3b53

Update TracerProviderBuilder.cs

1cac13f

TryFetch optional param to skip obj null check

d971dae

Make guard internal

8ba84c5

GuardTest doesn't need to be a static class

45d4caf

Update src/OpenTelemetry/DiagnosticSourceInstrumentation/PropertyFetc…

0b4c80e

…her.cs yes thank you, good catch Co-authored-by: Robert Pająk <[email protected]>

Update Guard.cs

964e9a6

Merge branch 'main' of https://github.com/mic-max/opentelemetry-dotnet

eae26ac

Add Compile Guard to required project files

169547a

Update OpenTelemetry.Instrumentation.Http.csproj

a473889

Merge branch 'main' into main

e256363

Merge remote-tracking branch 'upstream/main'

307ca0a

Merge remote-tracking branch 'upstream/main'

a67164e

Merge remote-tracking branch 'upstream/main'

ebe09e7

Merge remote-tracking branch 'upstream/main'

46deabc

Merge remote-tracking branch 'upstream/main'

88867c6

Merge remote-tracking branch 'upstream/main'

583e946

Merge remote-tracking branch 'upstream/main'

28c0299

Merge remote-tracking branch 'upstream/main'

18fc9c9

Merge remote-tracking branch 'upstream/main'

7734ff6

Merge remote-tracking branch 'upstream/main'

34f9c83

Merge remote-tracking branch 'upstream/main'

6dc71f0

Merge remote-tracking branch 'upstream/main'

d0d778d

Merge remote-tracking branch 'upstream/main'

c2f2284

mic-max and others added 2 commits March 3, 2023 14:16

Merge branch 'main' into otld-persist-failed-exports

251bdfe

update public api

b3b98f5

cijothomas reviewed Mar 6, 2023

View reviewed changes

mic-max added 4 commits March 6, 2023 13:11

runapicompat = false

cbad613

Merge branch 'otld-persist-failed-exports' of https://github.com/mic-…

adadf6d

…max/opentelemetry-dotnet into otld-persist-failed-exports

whitespace

17d404a

Update OpenTelemetry.Exporter.OpenTelemetryProtocol.PersistentStorage…

c7c362b

….Tests.csproj

Merge branch 'main' into otld-persist-failed-exports

b607f38

mic-max marked this pull request as ready for review March 7, 2023 00:36

mic-max requested a review from a team March 7, 2023 00:36

mic-max marked this pull request as draft March 7, 2023 00:36

mic-max added 2 commits March 7, 2023 10:35

undo sln change

f29cc17

Merge branch 'otld-persist-failed-exports' of https://github.com/mic-…

f42ae9b

…max/opentelemetry-dotnet into otld-persist-failed-exports

mic-max marked this pull request as ready for review March 7, 2023 18:36

CodeBlanch reviewed Mar 7, 2023

View reviewed changes

...rter.OpenTelemetryProtocol.PersistentStorage/OtlpTraceExporterPersistentStorageExtensions.cs Outdated Show resolved Hide resolved

CodeBlanch reviewed Mar 7, 2023

View reviewed changes

...rter.OpenTelemetryProtocol.PersistentStorage/OtlpTraceExporterPersistentStorageExtensions.cs Outdated Show resolved Hide resolved

Update OtlpTraceExporterPersistentStorageExtensions.cs

8c717c3

mic-max requested review from CodeBlanch, vishweshbankwar and cijothomas and removed request for CodeBlanch, vishweshbankwar and cijothomas March 8, 2023 20:18

attempt

095dad7

github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Mar 16, 2023

github-actions bot closed this Mar 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configuration of persistent storage to OTLP Exporter #4251

Add configuration of persistent storage to OTLP Exporter #4251

mic-max commented Mar 2, 2023

cijothomas Mar 6, 2023

vishweshbankwar Mar 6, 2023

Kielek Mar 8, 2023

cijothomas Mar 8, 2023

codecov bot commented Mar 7, 2023 •

edited

Loading

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 24, 2023

Add configuration of persistent storage to OTLP Exporter #4251

Add configuration of persistent storage to OTLP Exporter #4251

Conversation

mic-max commented Mar 2, 2023

Changes

cijothomas Mar 6, 2023

Choose a reason for hiding this comment

vishweshbankwar Mar 6, 2023

Choose a reason for hiding this comment

Kielek Mar 8, 2023

Choose a reason for hiding this comment

cijothomas Mar 8, 2023

Choose a reason for hiding this comment

codecov bot commented Mar 7, 2023 • edited Loading

Codecov Report

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 24, 2023

codecov bot commented Mar 7, 2023 •

edited

Loading